Remove duplicated InsufficientFunds error member #1441
Conversation
|
I tend to favor the name |
|
Please also setup commit signing, see: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification |
|
Maybe this belongs here better, basically, can this be disabled in anything but Network::Bitcoin? |
I personally don't think it's a good idea to "error-gate" based on the bitcoin::Network type, I would expect all behaviors that happen on mainnet (production per se) to happen on others, and even some nasty behaviors we may catch while testing on testnet/signet being prevented to land on mainnet code 😅. |
|
That's a good point, @oleonardolima maybe the juice is not worth the squeeze on making this change. |
e1a0a0ea
force-pushed
the
duplicated-insufficient-fund-error
branch
from
2cfae0b
to
9410137
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| @@ -4,7 +4,7 @@ use assert_matches::assert_matches; | |||
| use bdk::descriptor::{calc_checksum, IntoWalletDescriptor}; | |||
| use bdk::psbt::PsbtUtils; | |||
| use bdk::signer::{SignOptions, SignerError}; | |||
| use bdk::wallet::coin_selection::{self, LargestFirstCoinSelection}; | |||
| use bdk::wallet::coin_selection::{self, CoinSelectionError, LargestFirstCoinSelection}; | |||
There was a problem hiding this comment.
@e1a0a0ea Does this change still applies?
| available: remaining_amount.saturating_sub(*change_fee), | ||
| }); | ||
| return Err(CreateTxError::CoinSelection( | ||
| Error::InsufficientFunds { |
There was a problem hiding this comment.
@e1a0a0ea You could probably use a qualified version: coin_selection::Error::InsufficientFunds instead 🤔
There was a problem hiding this comment.
Or just import the InsufficientFunds variant itself.
|
Please rebase again and fixup commits into one commit then this should be ready to merge. |
closes #1440
Description
CreateTxError::InsufficientFundsuse bycoin_selection::Error::InsufficientFundsInsufficientFundsmember fromCreateTxErrorenumcoin_selection::Errortocoin_selection::CoinSelectionErrorNotes to the reviewers
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing