Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chapter 5 Figure 5-8 Correction #1022

Open
traffictse opened this issue Sep 17, 2022 · 0 comments
Open

Chapter 5 Figure 5-8 Correction #1022

traffictse opened this issue Sep 17, 2022 · 0 comments

Comments

@traffictse
Copy link

traffictse commented Sep 17, 2022 •
edited

The current Figure 5-9 titled "Creating master keys and chain code from a root seed" is quoted as:

image

According to BIP-39, the seed generated from a mnemonic is fixed as 512 bits due to the used hash function HMAC-SHA512. In the latest version of BIP-32 (from a PRNG), the seed is between 128 and 512 bits, with 256 bits advised.

Therefore, the text "Root Seed (128, 256, or 512 bits)" pointed from a mnemonic in the current Figure 5-8 needs to be fixed as "Root Seed (512 bits)", as shown in the following figure.

fig 5-9-2

Another alternative for Figure 5-8 is also attached though.

fig 5-9-1
@traffictse traffictse changed the title Chapter 5 Figure 5-9 Correction Chapter 5 Figure 5-8 Correction Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@traffictse