feat: is_offline command & handle reload and offline #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shall we add also a Tauri event so we can attach a listener on JS side instead of polling is offline command? |
|
That works as well but the question is when should we emit this event? |
|
Should we just emit is_offline if the load of service manifest fails, if we are just emitting once I think |
|
This PR conflicts with Registry PR in setup hook |
didn't checked the code yet, but I assume we should continuously monitor the state of the internet no? so when state changes (from online to offline or viceversa) we should emit the event |
|
closing will redo in a separate PR, rebasing is a lot more annoying than expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #476