-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PharmGKB parsing fixes #174
Comments
I have 2 comparisons for you here, the first one is the same record you linked above and another for different values. Comparison for https://mychem.info/v1/query?q=bromazin&fields=pharmgkb
generic_names and trade_names are now a list. Comparison for https://mychem.info/v1/chem/MCGSCOLBFJQGHM-SCZZXKLOSA-N?fields=pharmgkb
|
Commit 1ee8c29 fixes this issue, pending a new release. |
@DylanWelzel thanks for the quick fix. I noticed two more things I previously missed:
can we parse out each mixture string to an object:
can you verify if we have other possible value other than "gov" here? We might be able to further simplify this a bit as |
I came across this example here: https://mychem.info/v1/chem/AVKUERGKIZMTKX-NJBDSQKTSA-N?fields=pharmgkb.brand_mixtures.
How would we want this parsed into an object? Some possible options:
or
|
@DylanWelzel 2nd one |
80c7683 fix is live with the updated changes, example:
|
As shown in this example:
https://mychem.info/v1/query?q=bromazin&fields=pharmgkb
The text was updated successfully, but these errors were encountered: