-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-English months in PDB headers #4449
Comments
Where did this PDB file come from? I would argue it is technically an invalid file, but the current This could follow the existing strict/permissive mode behaviour, and using 0 or None for the month might be acceptable. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Setup
I am reporting a problem with Biopython version, Python version, and operating
system as follows:
(Please copy and run the above in your Python, and copy-and-paste the output)
Expected behaviour
In the PDB header there is a deposition date in
xx-xxx-xx
format. If this is filled out with non-english month month abbreviations (e.g. Okt for October or Ago for August), Biopython should assign the month to be'0'
as it does for thexxx
caseActual behaviour
Reproduced from
parse_pdb_header._format_date
function:Proposed solution:
We should make a check in the
_format_date
function that the string being checked is actually in theall_months
list and if not set the month to'0'
.The text was updated successfully, but these errors were encountered: