📎 Implement noYodaExpression - yoda

[michellocana]

Description

Issue just to keep track of my progress on the rule implementation, discussed here.
Implement the equivalent ESLint rule yoda to forbid the use of yoda expressions.

Options

We wont implement the part of the original rules that enforces the use of yoda expressions (always) as it seems that is rarely used.
The onlyEquality option is also used rarely so we will skip it for now.
The exceptRange option is more adopted so it's worth supporting it.

The snippets below are from the ESLint rule tests.

Valid

if (value === "red") {}
if (value === value) {}
if (value != 5) {}
if (5 & foo) {}
if (5 === 4) {}
if (value === `red`) {}
if (`red` === `red`) {}
if (`${foo}` === `red`) {}
if (`${""}` === `red`) {}
if (`${"red"}` === foo) {}
if (b > `a` && b > `a`) {}
if (`b` > `a` && "b" > "a") {}

Valid - Range expressions

if ("a" < x && x < MAX ) {}
if (1 < x && x < MAX ) {}
if ('a' < x && x < MAX ) {}
if (x < `x` || `x` <= x) {}
if (0 < x && x <= 1) {}
if (0 <= x && x < 1) {}
if ('blue' < x.y && x.y < 'green') {}
if (0 < x[``] && x[``] < 100) {}
if (0 < x[''] && x[``] < 100) {}

Invalid

if (x <= 'foo' || 'bar' < x) {}
if ("red" == value) {}
if (true === value) {}
if (5 != value) {}
if (5n != value) {}
if (null !== value) {}
if ("red" <= value) {}
if (`red` <= value) {}
if (`red` <= `${foo}`) {}
if (`red` <= `${"red"}`) {}
if (true >= value) {}
var foo = (5 < value) ? true : false
function foo() { return (null > value); }
if (-1 < str.indexOf(substr)) {}

[Conaclos]

I think we could just skip the implementation of exceptRange and assume it is enabled.

[michellocana]

I think we could just skip the implementation of exceptRange and assume it is enabled.

cool, will keep that in mind :)