Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lists as default arguments in functions #695

Closed
wants to merge 8 commits into from
Closed

Remove lists as default arguments in functions #695

wants to merge 8 commits into from

Conversation

vagos
Copy link

@vagos vagos commented Oct 31, 2023

Fixes #485

Replace lists as default arguments with the var = [] if var is None else var pattern.

@github-actions GitHub Actions
Copy link

OS:ubuntu-20.04
Tue Oct 31 14:39:13 UTC 2023
intro: 2/2 tests passed.
interface: 41/41 tests passed.
compiler: 54/54 tests passed.

@github-actions GitHub Actions
Copy link

OS = Debian 10
CPU = Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
Ram = 15752
Hash = 27b13fa
Kernel= Linux 4.15.0-197-generic x86_64

benchmark tests passed failed untested unresolved unsupported not_in_use other_status
posix 494 375 41 31 6 40 1 0
intro 2 2 0 0 0 0 0 0
interface 41 41 0 0 0 0 0 0
compiler 54 54 0 0 0 0 0 0

@angelhof
Copy link
Member

angelhof commented Nov 9, 2023

Thank you for this change @vagos, can you rebase this commit on future? Once you do that I will review and merge :)

@vagos
Copy link
Author

vagos commented Nov 9, 2023 •
edited

@angelhof No problem :) Will do

@vagos vagos changed the base branch from main to future November 9, 2023 21:09
Forthoney and others added 2 commits November 28, 2023 11:03
@Forthoney
Pin pash-annotations version
911110d 
PaSh Annotations will have some breaking changes introduced soon to its new minor version, so I pin its version to 0.2
@angelhof
Merge pull request binpash#705 from binpash/main-pin
e09e8d6 
Pin pash-annotations version
@angelhof
Copy link
Member

angelhof commented Dec 12, 2023 •
edited

Sorry @vagos, this fell through the cracks! If you can (and want), make a clean PR to future (with just your commit) and ping me so that I can see it and merge it immediately!

@vagos
Copy link
Author

vagos commented Dec 12, 2023

@angelhof No problem :) On it

@github-actions GitHub Actions
Copy link

OS:ubuntu-20.04
Mon Feb 12 15:57:42 UTC 2024
intro: 2/2 tests passed.
interface: 41/41 tests passed.
compiler: 54/54 tests passed.

@github-actions GitHub Actions
Copy link

OS = Debian 10
CPU = Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
Ram = 15752
Hash = 02f84f1
Kernel= Linux 4.15.0-197-generic x86_64

benchmark tests passed failed untested unresolved unsupported not_in_use other_status
posix 494 375 41 31 6 40 1 0
intro 2 2 0 0 0 0 0 0
interface 41 41 0 0 0 0 0 0
compiler 54 54 0 0 0 0 0 0

@angelhof angelhof closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove empty lists as default arguments in functions
4 participants
@vagos @angelhof @nikpag @Forthoney