Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECHDEBT] Parsing of sword:// URLs is non-uniform #387

Open
jaakristioja opened this issue May 13, 2022 · 0 comments
Open

[TECHDEBT] Parsing of sword:// URLs is non-uniform #387

jaakristioja opened this issue May 13, 2022 · 0 comments
Assignees
Labels
Milestone

Comments

@jaakristioja
Copy link
Member

Summary

Libsword and BibleTime sometimes generate links in the sword: scheme, which are in many places parsed by BibleTime using many different regular expressions, instead of there being a single function or class to parse these URLs.

Consequences

Since parsing of these URLs is done in multiple places using multiple different means, it is prone to deviate towards erronous program logic, e.g. not handling all cases of URLs.

Remediation approach

Both parsing and generation of such URLs should be refactored into a single place, perhaps using some approach based on or similar to QUrl.

Notes

See also #386.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant