-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix v11n mapping in parallel views #361
Comments
after inspecting core rendering pipeline i think 2. is best choice, it already have related functionality at I think Also i think it would be possible to remove this parameter that is often unused: - CTextRendering::renderEntry(KeyTreeItem const & i, CSwordKey * k)
+ CTextRendering::renderEntry(KeyTreeItem const & i) So parallel mode case will be handled by mapping |
Inspecting v3.0.2 code i found that
BtModuleTextModel
render text for verses in parallel mode for each module separately, without passing context of all rendering modules. That makes impossible to translate versifications.Inspecting rendering pipeline i found correct that text items are selectable for each module separately, so requirement to render
a single verse in parallel view looks justified.
I also would note that i do not get yet, why that model use multiple data roles rather than utilize columns.
So i would make following suggestions to resolve this issue:
CEntryDisplay::textKeyRendering()
and still pass full module list.key
parameter ofCEntryDisplay::textKeyRendering()
tosword::SWKey
or somewhat like that so it would be casted toVerseKey
and translated to v11n of requested module.In sense of performance i think 1. and 2. are better, but i still would like to have flexible basic text model with good design so it would be easily reused and improved.
The text was updated successfully, but these errors were encountered: