Refactor rendering to use CSwordKey as a key to render #363
+134
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since you want to merge it into wip/kalemas/fix-verse-range-rendering-in-info is suppose this depends on pull request #362? |
jaakristioja
reviewed
Jan 9, 2022
jaakristioja
reviewed
Jan 9, 2022
jaakristioja
reviewed
Jan 9, 2022
Yes, i m sure it require changes from that PR but for review i d prefer to not mix changes from another PR. So i will proceed to develop this and will propose ready to merge variant next time. |
kalemas
force-pushed
the
wip/kalemas/fix-verse-range-rendering-in-info
branch
from
ad67bc7
to
c7ad0fe
Compare
kalemas
changed the base branch from
wip/kalemas/fix-verse-range-rendering-in-info
to
stable-3.0
kalemas
force-pushed
the
wip/kalemas/refactor-rendering
branch
from
fc888df
to
f7a3e06
Compare
kalemas
changed the base branch from
stable-3.0
to
wip/kalemas/fix-verse-range-rendering-in-info
kalemas
force-pushed
the
wip/kalemas/refactor-rendering
branch
4 times, most recently
from
94f58c2
to
ee1e9dc
Compare
kalemas
force-pushed
the
wip/kalemas/refactor-rendering
branch
from
ee1e9dc
to
839b7c8
Compare
|
@jaakristioja i think that this may be reviewed now. I would say fair, i see no problems with passing by pointer/references, constancy. I also split main commit in two that changing methods signatures. |
|
it is now rendered correctly at my sight |
kalemas
force-pushed
the
wip/kalemas/fix-verse-range-rendering-in-info
branch
from
be2b6f4
to
ece8bf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolve issue when parallel view didn't respected mapping between versifications.
I expect it will also bring some architecture optimizations. Now it is just a rough idea of change so many things have to be reconsidered and deduplicated before merge.
Modern cpp moved forward so i m not sure it follows best practices, please correct me.