Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC button not showing up for Youtube videos #445

Open
Lefthandmedia opened this issue Sep 8, 2023 · 5 comments
Open

CC button not showing up for Youtube videos #445

Lefthandmedia opened this issue Sep 8, 2023 · 5 comments

Comments

@Lefthandmedia
Copy link

Lefthandmedia commented Sep 8, 2023

Describe the bug
Well the CC button is not showing up for Youtube videos. It does for vimeo.
I can see the markup for it with a display:none . But i expect it to be visible when the 'captions' option is in the controls array.

Are you able to reproduce the bug in the demo site
The demo site also does not show a CC button for the Youtube video

To Reproduce
Steps to reproduce the behavior:
initialise a Glightbox, have the 'captions' in the controls [array], link a you tube video.

Expected behavior
i expect the CC button to be visible in the controlbar when the 'captions' option is in the controls array.

Post the code you are using
const Mylightbox = GLightbox({ selector: .lightbox, touchNavigation: true, loop: true, autoplayVideos: true, plyr: { css: 'https://cdn.plyr.io/3.7.8/plyr.css', js: 'https://cdn.plyr.io/3.7.8/plyr.js', config: { ratio: null, // or '4:3' controls: ['play-large', 'play', 'progress', 'current-time', 'mute', 'volume', 'captions', 'settings', 'pip', 'airplay', 'fullscreen'], }, }, });

Screenshots

Screenshot 2023-09-08 151705
@biati-digital
Copy link
Owner

GLightbox does not modify the player interface at all, if captions are hidden it must be something related to Plyr. GLightbox simply passes your configuration to Plyr and that's it. Not sure if this is a know issue but you'll have more luck asking in the Plyr repo.

@Lefthandmedia
Copy link
Author

Posted an issue there as well ( sampotts/plyr#2744 ). That said, it looks like PLYR is a dying project moving towards Vidstack. issues are no longer dealt with or answered by maintainer. Is there an alternative for PLYR?

@gingerchew
Copy link
Collaborator

gingerchew commented Oct 13, 2023

Currently, none that I know of. They were kind of in a league of their own. The one that was used in previous versions has gone paid only.

@biati-digital
Copy link
Owner

This is something we need to consider, Vidstack does not support Youtube or Vimeo yet.

Probably we'll keep Plyr until Vidstack is ready. Plyr is not perfect but seems to be the best option for now.

@Lefthandmedia
Copy link
Author

Vidstack seems to support Youtube and Vimeo now. https://www.vidstack.io/docs/player
Features; Multiple media provider support: Audio, Video, HLS, DASH (soon), YouTube, Vimeo, and Remotion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants