-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS overblown and too opinionated? #13
Comments
Even better, no css! |
We could separate the CSS out, or pass style variables. Probably the latter! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey Antony,
I've been taking a look at the CSS and how things work, and think its a bit overblown based on how Svelte works.
example for FacebookAuth.svelte in the CSS section there is this
However, svelte by design will add a unique css class thus rendering this inefficient.
this code above would perform the same task without extra dross. I'm not suggesting to remove the class from the html, as someone might want to add further styling via a global CSS.
In addition to this, I find its quite opinionated in the way it has to be displayed. Things like the button color, text color and button width for me should be adaptable without having to fork and re-write the base.
Suggesting something like this:
As I said, I'd rather not fork this so I can continue to get updates if there are any, so I'm thinking there should be 4 new attributes
Before I make a PR with this, I just wanted to run it by you to see what your thoughts are?
The text was updated successfully, but these errors were encountered: