Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bevy_time optionally depend on bevy_reflect #13246

Closed
notmd opened this issue May 5, 2024 · 1 comment · Fixed by #13263
Closed

Make bevy_time optionally depend on bevy_reflect #13246

notmd opened this issue May 5, 2024 · 1 comment · Fixed by #13263
Labels
C-Enhancement A new feature D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon

Comments

@notmd
Copy link
Contributor

notmd commented May 5, 2024

What problem does this solve or what need does it fill?

I have a use case where I use bevy_time but it depend on bevy_reflect which I don't need.

What solution would you like?

Add reflect feature flag like in bevy_ecs and turn it on by default so I can opt-out.

What alternative(s) have you considered?

None

Additional context

None
@notmd notmd added C-Enhancement A new feature S-Needs-Triage This issue needs to be labelled labels May 5, 2024
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy X-Uncontroversial This work is generally agreed upon D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! and removed S-Needs-Triage This issue needs to be labelled D-Trivial Nice and easy! A great choice to get started with Bevy labels May 5, 2024
@alice-i-cecile
Copy link
Member

I'd be very happy to see this done, if you're interested in making a PR.

@juliohq juliohq mentioned this issue May 6, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 12, 2024
@juliohq
Make bevy_time optionally depend on bevy_reflect (#13263)
de7ff29 
# Objective

Fixes #13246.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Enhancement A new feature D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make bevy_time optionally depend on bevy_reflect juliohq/bevy
2 participants
@alice-i-cecile @notmd