Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

"halloactivated" event handler isn't unhooked on destroy() #258

Open
bcdickinson opened this issue Jul 7, 2017 · 0 comments
Open

"halloactivated" event handler isn't unhooked on destroy() #258

bcdickinson opened this issue Jul 7, 2017 · 0 comments

Comments

@bcdickinson
Copy link

In hallo's _create method, there's a one-time event handler wired up to "halloactivated":

@element.one 'halloactivated', =>
   # We will populate the toolbar the first time this
   # editable is activated. This will make multiple
   # Hallo instances on same page load much faster
   @_prepareToolbar()

If you destroy the widget before it's been activated and then reinitialise it with a different set of plugins you get an error when the widget is first activated thrown from the handler whose set of plugins no longer matches`:

$(myElement).hallo({ plugins: { halloformat: {} });
$(myElement).hallo('destroy');
$(myElement).hallo({ plugins: { hallolists: {} });
$(myElement).click();
// Uncaught Error: Plugin halloformat not found

I'm just manually calling $(myElement).off('halloactivated') as a workaround for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant