Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it make sense that Total doesn't include any amounts currently in a pending trade? #37

Open
kalepail opened this issue Jan 17, 2018 · 1 comment

Comments

@kalepail
Copy link

I would like and expect to see the total amount for any coin to include any amounts in pending trades. Seems to be a little inconsistent too as GDAX seems to do this but Binance does not. Curious if this is an API limitation or expected behavior or what.

@benmarten
Copy link
Owner

benmarten commented Jan 22, 2018

That is expected behavior at this point, as most exchanges will return you something like this as response:

{
  "holdings": [],
  "holdingsOnTrades": []
}

I guess this would require looking at the respective response again and adding these coins too...
Feel free to set a breakpoint in the binance integration and inspect the response body...
Keeping this open for now, as its prob. a good enhancement ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants