feat: history buffer #139
Draft
feat: history buffer #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I think I'm dealing with an image.nvim bug here. when the history buffer exists (even if it's not open), image rendering breaks. 
The reason I think this is an image.nvim issue, is that causing a re-render (either by folding and unfolding or by unfocusing and refocusing the editor) will render the images like normal. |
|
I think this will have to wait for the image.nvim rewrite.. Hopefully that will fix a lot of the bugs that this PR is dealing with. |
|
The latest image.nvim change fixed the worst of these problems. There are still some issues with images unlinking themselves and hanging around though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #138
Currently MVP. There's a split history window that shows the history of the current cell when you open it.
TODO:
[ ] Ability to show global history[ ] Timestamps?I think that I'm going to scrap the ability to view this in a floating window. Doesn't seem that useful to me.
Also pushing time stamps and global history to later PRs b/c this one is already really big.