Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission error in Brave browser #34

Open
fengtality opened this issue Mar 13, 2019 · 11 comments
Open

Submission error in Brave browser #34

fengtality opened this issue Mar 13, 2019 · 11 comments

Comments

@fengtality
Copy link

fengtality commented Mar 13, 2019

When testing the v2 example in the Brave browser (https://brave.com/), the plugin throws an error upon submission rather than returning the Mailchimp response:

err Error: Timeout
    at index.js:63 

index.js is /node_modules/jsonp/index.js

@benjaminhoffman
Copy link
Owner

this is usually the result of:

  • invalid or missing mailchimp endpoint
  • captcha enabled
  • ad blockers

can you confirm it's non of the above? thx

@fengtality
Copy link
Author

This is definitely an issue with the Brave browser, which aggressively blocks external API calls as part of their ad blocking. Others have reported similar issues. https://community.brave.com/t/mailchimp-website-widget-unresponsive-to-submit-button/12788

We added some (hacky) JS to detect when the error occurs and tell users to change their Brave browser setting:

      if (err.message === 'Timeout') {
        this.setState({
          braveWarning: 'Looks like you are using Brave browser - please click the shield icon and toggle off "Ads and trackers blocked", then re-submit your email.'
        })
      }

Screen Shot 2019-05-01 at 4 10 25 PM

@ghost
Copy link

ghost commented Aug 8, 2019

This issue happens with firefox too, but if you embed the mailchimp form it doesnt have the issue

@benjaminhoffman
Copy link
Owner

benjaminhoffman commented Aug 31, 2019

I've consolidated a few issues, including this one, into #48. If someone wants to open a PR of @mifeng's (temporary) solution, that would be helpful! If not, I'm happy to do so within a month or so.

@jpvalery
Copy link

jpvalery commented Sep 5, 2019

This is definitely an issue with the Brave browser, which aggressively blocks external API calls as part of their ad blocking. Others have reported similar issues. https://community.brave.com/t/mailchimp-website-widget-unresponsive-to-submit-button/12788

We added some (hacky) JS to detect when the error occurs and tell users to change their Brave browser setting:

      if (err.message === 'Timeout') {
        this.setState({
          braveWarning: 'Looks like you are using Brave browser - please click the shield icon and toggle off "Ads and trackers blocked", then re-submit your email.'
        })
      }
Screen Shot 2019-05-01 at 4 10 25 PM

Hey @mifeng,

Where did you add this?

This could be easily changed into something generic like

      if (err.message === 'Timeout') {
        this.setState({
          warning: 'Looks like your browser is blocking this. Try to disable any tracker-blocking feature and resubmit.'
        })
      }

I feel this would be doing the trick for most of the users out there and avoid people leaving because it appears broken?

Thanks for your help!

@jpvalery
Copy link

@benjaminhoffman is this still on your radar?

@benjaminhoffman
Copy link
Owner

yes! so sorry. just been super swamped. let me see if i can get to it this weekend, but at worst, i will do before feb.

@jpvalery
Copy link

No worries, totally understand :) Let me know if I can be of any help

@ghost
Copy link

ghost commented Feb 2, 2020

@benjaminhoffman did you check the calendar? :P

@benjaminhoffman
Copy link
Owner

@littlehamster fastest way to get this solved is by opening a PR! :) will do my best to get to it but got a million other things going on too.

@ghost
Copy link

ghost commented Feb 2, 2020

@benjaminhoffman
yeah no worries, just wanted to follow up. I am not sure how I can help except the info I shared here #45

right now I am just embeding the code directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants