Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images per row #122

Open
sT0pe opened this issue Jul 8, 2019 · 3 comments
Open

Images per row #122

sT0pe opened this issue Jul 8, 2019 · 3 comments

Comments

@sT0pe
Copy link

sT0pe commented Jul 8, 2019

thumbnail 100x100
rowHeight={100}

Expected behaviour

gallery wrapper width < 300 than third image goes to second row

Actual behaviour

Third image goes down only after width <=200

So is it possible do not compress images, but if there is no enough space just move to the next row?

@mattg66
Copy link

mattg66 commented Nov 18, 2020

I am also looking for this, I am not hopeful though as the project has been abandoned

@itoldya
Copy link
Collaborator

itoldya commented Aug 10, 2022

Hello @sT0pe and @mattg66 👋

Do you want thumbnails to keep the original aspect ratio, i.e. no edges have been cut? React-grid-gallery uses compression for the gallery to have all rows completely filled. It's the main idea of the library. If it hasn't been done gallery may look like this on some resolutions. Is that behavior your ask for?

Снимок экрана 2022-08-10 в 20 52 25

The original gallery used on photos.google.com doesn’t do compression of images. Instead, it can vary row height to avoid incomplete rows. I think it's interesting and we may implement this strategy as an option in the next releases.

Can you please clarify your use case?

@sT0pe
Copy link
Author

sT0pe commented Aug 11, 2022

Hi @itoldya, yes that is exactly what I was looking for in 2019. Would be nice to have an option for such behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants