Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default loss function should use log ratio, not subtraction #137

Open
adamabeshouse opened this issue May 15, 2019 · 0 comments
Open

Default loss function should use log ratio, not subtraction #137

adamabeshouse opened this issue May 15, 2019 · 0 comments

Comments

@adamabeshouse
Copy link

adamabeshouse commented May 15, 2019

We're using your work for an upcoming release of cbioportal.org. We wanted more control over the rendering, so we used your exposed algorithms for computing layout, and manually rendering the circles using that layout. This has been a godsend, thank you.

But I discovered an issue - sometimes, in a particularly tight layout situation, the circles would layout so as to appear that an actually empty intersection is not empty.
For example:
image

I was able to fix this on our end by copying over the loss function but modifying this line
https://github.com/benfred/venn.js/blob/master/src/layout.js#L416

to turn it into
image

I believe this is better because as described in the screenshot, it weights small sets equally. I don't have time to open a PR but I wanted to drop this idea in because I think it's a good one.

The result is:
image

@adamabeshouse adamabeshouse changed the title Default loss function should use log ratio loss, not difference Default loss function should use log ratio, not difference May 15, 2019
@adamabeshouse adamabeshouse changed the title Default loss function should use log ratio, not difference Default loss function should use log ratio, not subtraction May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant