-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catch2 time units are ignored when graphing and generating alerts #122
Labels
bug
Something isn't working
Comments
Any news on this? github-action-benchmark/src/write.ts Line 567 in 8e74972
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using the "catch2" extractor, the time units, "ms", "us", etc, are extracted and printed, but otherwise ignored.
This results in broken graphs when the time is near a unit boundary:
It also results in false alerts:
The text was updated successfully, but these errors were encountered: