Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image inside Link doesn't match properly #74

Open
yz89122 opened this issue Mar 14, 2021 · 1 comment
Open

Image inside Link doesn't match properly #74

yz89122 opened this issue Mar 14, 2021 · 1 comment

Comments

@yz89122
Copy link

yz89122 commented Mar 14, 2021

Describe the bug

[Title ![badge](https://example.com/badge.png)](./article.md)

link = link_parts(Regexp.last_match)

link_type, link_text, relative_path, fragment = link_parts(Regexp.last_match)
# link_type: "inline"
# link_text: "Title ![badge"
# relative_path: "https://example.com/badge.png"

Steps to reproduce the behavior

Expected behavior

link_type, link_text, relative_path, fragment = link_parts(Regexp.last_match)
# link_type: "inline"
# link_text: "Title ![badge](https://example.com/badge.png)"
# relative_path: "./article.md"

and

link_type, link_text, relative_path, fragment = link_parts(Regexp.last_match)
# link_type: "inline"
# link_text: "badge"
# relative_path: "https://example.com/badge.png"

Screenshots

Additional context

@LesFerch
Copy link

LesFerch commented Feb 8, 2022

If I'm reading the above correctly, I am encountering the same issue.

Text links like this are properly converted to an HTML link:
Manual

Links, like the one below, containing an image, do not get converted:
imageManual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants