Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on end of life System.Reflection.Metadata 5.0.0 #205

Open
TFTomSun opened this issue Sep 21, 2022 · 3 comments
Open

Dependency on end of life System.Reflection.Metadata 5.0.0 #205

TFTomSun opened this issue Sep 21, 2022 · 3 comments

Comments

@TFTomSun
Copy link

The latest Ben.Demystifier package has a dependency on System.Reflection.Metadata 5.0.0.

https://www.nuget.org/packages/Ben.Demystifier#dependencies-tab

.NET 5 is out of support / end of life.
https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core

Is it possible to push a new version with a dependency to the latest Dotnet SDK (currently 6)?

@Aragas
Copy link

Aragas commented Nov 25, 2022

Could the current version be kept?
We just integrated it in Bannerlord.ButterLib, a Mount & Blade II: Bannerlord mod that shows a crash report when an unhandled exception occurs. The game uses .NET Framework, so the demystifier really helps with providing a readable stack trace!
The issue is, we can't control version dependency version redirects, so we stick to the dependencies that don't cause binding issues. With Microsoft.Extensions.* libraries we target 2.0.0, for example. Same goes with System.Reflection.Metadata!

At least, right now there should be no difference if 5.* or 6.* versions are used, because the ABI is the same. Users of standard (enterprise) projects could manualy update their System.Reflection.Metadata to the latest available, as it will contain the latest bug fixes avaiable!

@mattjohnsonpint
Copy link

Minimal dependencies don't need to be bumped just because they're EOL. That just removes compatibility with older versions, with no benefit to newer ones.

If you want to use a newer version, then take an additional reference to the newer version.

The right path forward here is that Ben.Demystifier should add a net6.0 target that conditionally removes the dependency on System.Reflection.Metadata. Then newer versions of .NET would use the one they ship with.

@AartBluestoke
Copy link

The latest Ben.Demystifier package has a dependency on System.Reflection.Metadata 5.0.0.

https://www.nuget.org/packages/Ben.Demystifier#dependencies-tab

.NET 5 is out of support / end of life. https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core

Is it possible to push a new version with a dependency to the latest Dotnet SDK (currently 6)?

the dependency is "System.Reflection.Metadata (>= 5.0.0)"
you can use any newer non-end of life version you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants