Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of selection is off by one when selecting lines #326

Open
l0b0 opened this issue Mar 5, 2024 · 0 comments
Open

End of selection is off by one when selecting lines #326

l0b0 opened this issue Mar 5, 2024 · 0 comments

Comments

@l0b0
Copy link

l0b0 commented Mar 5, 2024

Thank you for this fantastic plugin!

One nit is that I often select a bunch of lines (for example using Ctrl+w to expand the selection), and the resulting link created by GitLink includes the last line, even though I've not selected anything on that line. The last selected character is the newline before that line.

A couple of screenshots should clarify. I've triple-clicked line 12 to select that line:

image

If I right-click and press "Open in GitHub" (same result on GitLab), it goes to this page, where the next line is also selected:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant