Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive import session should offer a "Retry" choice in case of MusicBrainz server error #2575

Open
bartkl opened this issue May 25, 2017 · 3 comments
Labels
feature features we would like to implement

Comments

@bartkl
Copy link
Contributor

bartkl commented May 25, 2017

When importing using the autotagger, sometimes the MusicBrainz server is not reachable, which gives an error like:
Error: MusicBrainz not reachable in get release ...
In case the import session is interactive, the user gets prompted with the usual choice dialog. It would be very nice if an extra option [R]etry is added in this situation, since quite often it's not server downtime but just hickups (also possibly on your own end). Now I have to skip the album in case I'd like to retry the autotagging process, which is especially tedious if it concerns a mass import.

Would love to hear your thoughts.

@peace899
Copy link

I thought musicbrainzngs already has max 8 retries with each API call. As per python-musicbrainzngs issue #174

I'm not sure but I think on each exception, it retries 8 times to do your request? Maybe someone who knows better can explain.

@sampsyo
Copy link
Member

sampsyo commented May 25, 2017

It does indeed retry several times before giving up. Of course, there is a chance that waiting a while (for the user to respond) would be enough to clear things up. For example, if the network connection is down, the user can reconnect the cable and then retry.

This seems like a good addition. It's not 100% clear how the layering problems will be solved here, but it's worth a try.

@sampsyo sampsyo added the feature features we would like to implement label May 25, 2017
@sampsyo sampsyo changed the title Interactive import session should Retry choice in case of MusicBrainz server error Interactive import session should offer a "Retry" choice in case of MusicBrainz server error May 25, 2017
@arcresu
Copy link
Member

arcresu commented Apr 29, 2019

Just to note that this is related to #2219. Both could potentially be solved by a solution along the lines of #266 where beets keeps track of when a metadata plugin has acted on a given Item. If we knew which Items in the library hadn't been processed (e.g. due to transient communication issues over an API) then it would be possible to re-run the plugin over just those instead of re-scanning the whole library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

4 participants