Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Tap to Copy+Tap to Reveal no longer works correctly #1223

Open
Bazoogle opened this issue Nov 16, 2023 · 4 comments
Open

Single Tap to Copy+Tap to Reveal no longer works correctly #1223

Bazoogle opened this issue Nov 16, 2023 · 4 comments
Labels
bug A bug report

Comments

@Bazoogle
Copy link

Version

v2.2.2

Source

F-Droid

Vault encryption

Yes (with biometric unlock)

Device

Moto Edge 2021

Android version

Android 13

ROM

LineageOS 20

Steps to reproduce

Settings -> Behavior -> Copy tokens to clipboard: Single tap
Settings -> Security -> Tap to reveal: enabled

Restart app, then when tap a token.

What do you expect to happen?

Previously, when you tapped the hidden token, it would reveal it. If you tapped it a second time, it would copy and minimize the app.

What happens instead?

When you tap it the first time, it immediately copies the value and minimizes. In order to view the token to enter on another device, I have to view my clipboard.

Log

No response

@Bazoogle Bazoogle added the bug A bug report label Nov 16, 2023
@michaelschattgen
Copy link
Member

michaelschattgen commented Nov 27, 2023

I'm afraid I don't quite understand what the bug is you're describing.

When you tap it the first time, it immediately copies the value and minimizes. In order to view the token to enter on another device, I have to view my clipboard.

This is the intended behavior when you set "Copy to clipboard" to single tap and enable "Tap to reveal". What exactly do you want to happen?

EDIT: After rereading your report it seems like you want to avoid minimizing the app? That's another setting in the "Behavior" section of Aegis. You can either disable "Minimize on copy" or set "Copy to clipboard" to never or double tap. Hope this helps.

@Practicalbutterfly5
Copy link

How do I bring back the old behaviour.
The old behaviour with tap to copy and hidden secrets worked like so

  1. On opening the apps, secrets are hidden.
  2. Tap to reveal the secret. This is useful if I want to use totp on another device.
  3. Tap revealed secret again to copy to clipboard.

How can I restore the old behaviour now?
The closest I have got is to disable hidden secrets and enable single tap to copy.

I think there should be some option to restore the old behaviour.

@Bazoogle
Copy link
Author

After rereading your report it seems like you want to avoid minimizing the app? That's another setting in the "Behavior" section of Aegis. You can either disable "Minimize on copy" or set "Copy to clipboard" to never or double tap. Hope this helps.

I don't want to avoid minimizing the app, rather I'd like it to copy and minimize on tap only if the token is revealed (like it originally did). This means if the token is hidden, the tap would not copy the token and minimize, but simply reveal the token. If I am copying it I am going to a different app on my phone, so the app will need to be minimized anytime I copy it, whether manually or automatically. The original functionality is what I want. The tap to copy (and consequently minimize) should only apply once the token is revealed. I suppose technically this is no longer "single tap" given you have to tap it once to reveal it, and then a second time to do the actual copying. Though it is still only one tap after you can see the token.

I'm not sure if the change was intentional or accidental. I assumed accidental, which is why I marked it as a bug report.

@ibrahimjelliti
Copy link

are there any updates on this bug, copy to clipboard doesn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report
Projects
None yet
Development

No branches or pull requests

4 participants