Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mk_plate_scoring_functions with plate agnostic scoring functions will not work in current setup #23

Closed
julianesiebourg opened this issue Aug 21, 2023 · 3 comments
Assignees

Comments

@julianesiebourg
Copy link
Collaborator

in the current optimize_multi_plate_design function for each plate a plate specific scoring function is generated with mk_plate_scoring_function. For these scoring functions a plate specific distance matrix is pre-calculated that will be used every time the scoring is done. Such pre-calculation would not be possible if we want to use the scoring functions in a 'group_by' manner and apply them on the fly to a given subset (plate) of all samples.

@julianesiebourg
Copy link
Collaborator Author

@idavydov & @banfai Does this summarize what we discussed?

@idavydov
Copy link
Collaborator

thanks, @julianesiebourg . yes, perfect.

One thing we discussed @ingitwetrust , if a scoring function can cache all the necessary object on the first run or if it detects change in the bc$locations_df or the sample sheet.

@idavydov
Copy link
Collaborator

@ingitwetrust kindly volunteered to fix this via #47 as far as I understand.

so I'm closing this in favor of the new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants