Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "group" tag omitted when using job-submit --combine #170

Open
pity4yeats opened this issue Jan 18, 2023 · 0 comments
Open

[BUG] "group" tag omitted when using job-submit --combine #170

pity4yeats opened this issue Jan 18, 2023 · 0 comments
Labels

Comments

@pity4yeats
Copy link

Describe the bug
When using bkr job-submit --combine to combine several jobs into a single job, the "group" tag in the job XMLs to be combined is omitted.

Version-Release number
beaker-client-28.3-3.fc37.noarch
beaker-common-28.3-3.fc37.noarch

To Reproduce
Steps to reproduce the behavior:

  1. Prepare 2 job XMLs with the same contents of the following (notice that in the 1st line group="some-group-in-beaker"):
<job retention_tag="120days" group="some-group-in-beaker">
	<whiteboard>example job xml</whiteboard>
	<recipeSet priority="Normal">
		<recipe whiteboard="BaseOS" ks_meta="harness='restraint-rhts beakerlib-redhat' disable_repo_CRB disable_repo_CRB-debuginfo">
			<distroRequires>
				<and>
					<distro_name op="=" value="RHEL-9.0.0"/>
					<distro_variant op="=" value="BaseOS"/>
					<distro_arch op="=" value="x86_64"/>
				</and>
			</distroRequires>
			<hostRequires/>
			<repos/>
			<partitions/>
			<watchdog panic="ignore"/>
			<task name="/distribution/reservesys" role="None">
				<params>
					<param name="RESERVETIME" value="604800"/>
				</params>
				<rpm name="test(/distribution/reservesys)" path="/mnt/tests/distribution/reservesys"/>
			</task>
		</recipe>
	</recipeSet>
</job>
  1. Say the 2 files are named a.xml and b.xml
  2. bkr job-submit --combine --xml --dry-run a.xml b.xml

Actual behavior
Only retention_tag is kept, but group="some-group-in-beaker" doesn't present in the resulting XML:

<job retention_tag="120days"><whiteboard>example job xml</whiteboard><recipeSet priority="Normal">
		<recipe whiteboard="BaseOS" ks_meta="harness='restraint-rhts beakerlib-redhat' disable_repo_CRB disable_repo_CRB-debuginfo">
...
		</recipe>
	</recipeSet><recipeSet priority="Normal">
		<recipe whiteboard="BaseOS" ks_meta="harness='restraint-rhts beakerlib-redhat' disable_repo_CRB disable_repo_CRB-debuginfo">
...
		</recipe>
	</recipeSet></job>

Expected behavior
group="some-group-in-beaker" doesn't get omitted in the resulting XML, for example:

<job retention_tag="120days" group="some-group-in-beaker"><whiteboard>example job xml</whiteboard><recipeSet priority="Normal">
		<recipe whiteboard="BaseOS" ks_meta="harness='restraint-rhts beakerlib-redhat' disable_repo_CRB disable_repo_CRB-debuginfo">
...
		</recipe>
	</recipeSet><recipeSet priority="Normal">
		<recipe whiteboard="BaseOS" ks_meta="harness='restraint-rhts beakerlib-redhat' disable_repo_CRB disable_repo_CRB-debuginfo">
...
		</recipe>
	</recipeSet></job>

Screenshots

Additional context

@pity4yeats pity4yeats added the bug label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant