Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style fixes | keep this open #410

Closed
14 tasks done
CraigClark opened this issue Apr 3, 2024 · 16 comments
Closed
14 tasks done

Style fixes | keep this open #410

CraigClark opened this issue Apr 3, 2024 · 16 comments
Assignees
@CraigClark
Labels
Sprint 15 March 14 - April 3 Sprint 16 April 4- April 24 Sprint 17 April 25 - May 16 Sprint 18 May 17 - May 30 task a task that a dev team member needs to address
Milestone
Theming

Comments

@CraigClark
Copy link
Collaborator

CraigClark commented Apr 3, 2024 •
edited

OP timer

https://openplus.monday.com/boards/4092908516/pulses/6381923925

This task will stay open. It's for small changes we need to make to the theme. These changes aren't big enough to need their own issue, but they're still important to keep track of.

  • Increase spacing between items on the data dictionary paragraph edit form. see Look at UX for placement of field help text #409
  • more space below logo on header so logo is horizontally centred
    image
  • Additional space above active period on info schedule term page as per #392
  • Add margin to top of footer for readability
    image
  • Move devel styles to proper style sheets
  • Decrease spacing between page title and underline
  • fix inconsistent font weight on field labels on build pages form view
  • add space above sidebar on mobile
    image
  • ensure consistency across the reports - done as part of Pager not working as expected for taxonomy overview page #441
  • make the manage page use the same exposed filter style as the report builder
  • on dashboard, move search bar to the header and make the manage records look decent
  • make sure all booleans are explicit yes/no and display inline (pending @NicoledeGreef approval)
  • Fix sidebar on book pages that touch the side of the screen on mobile
  • in the build pages, source system has too much space between the label and the input field
@CraigClark CraigClark added task a task that a dev team member needs to address Sprint 15 March 14 - April 3 Sprint 16 April 4- April 24 labels Apr 3, 2024
@CraigClark CraigClark added this to the Theming milestone Apr 3, 2024
This was referenced Apr 3, 2024
Closed
Closed
@CraigClark CraigClark self-assigned this Apr 10, 2024
@CraigClark CraigClark changed the title Style fixes Style fixes | keep this open Apr 10, 2024
@CraigClark
Copy link
Collaborator Author

CraigClark commented Apr 10, 2024 •
edited by lkmorlan

@lkmorlan Please review/merge:

lkmorlan added a commit that referenced this issue Apr 10, 2024
@lkmorlan
Issue #410: Update bcbb_theme
aa01e0e
lkmorlan pushed a commit that referenced this issue Apr 10, 2024
@CraigClark @lkmorlan
Issue #410: Add spacing and border around input fields on a data dict…
e29bc3a 
…ionary
lkmorlan pushed a commit that referenced this issue Apr 10, 2024
@CraigClark @lkmorlan
Issue #410: Add space between info schedule details and classificatio…
b3e0112 
…n fields
@lkmorlan
Copy link
Collaborator

Merged

CraigClark pushed a commit that referenced this issue Apr 15, 2024
@lkmorlan @CraigClark
Issue #410: Update bcbb_theme
e2b0cf8
CraigClark added a commit that referenced this issue Apr 15, 2024
@CraigClark
Issue #410: Add spacing and border around input fields on a data dict…
e9fb94b 
…ionary
CraigClark added a commit that referenced this issue Apr 15, 2024
@CraigClark
Issue #410: Add space between info schedule details and classificatio…
1121971 
…n fields
@CraigClark
Copy link
Collaborator Author

CraigClark commented Apr 17, 2024 •
edited by lkmorlan

@lkmorlan please review/merge

lkmorlan pushed a commit that referenced this issue Apr 17, 2024
@CraigClark @lkmorlan
Issue #410: Move development styles to theme
1ecacd5
@lkmorlan
Copy link
Collaborator

Merged

CraigClark pushed a commit that referenced this issue Apr 19, 2024
@lkmorlan @CraigClark
Issue #410: Update bcbb_theme
0aa5407
CraigClark added a commit that referenced this issue Apr 19, 2024
@CraigClark
Issue #410: Add spacing and border around input fields on a data dict…
0354955 
…ionary
CraigClark added a commit that referenced this issue Apr 19, 2024
@CraigClark
Issue #410: Add space between info schedule details and classificatio…
29ee1a5 
…n fields
CraigClark added a commit that referenced this issue Apr 19, 2024
@CraigClark
Issue #410: Move development styles to theme
89c236e
CraigClark added a commit that referenced this issue Apr 22, 2024
@CraigClark
make dependency report have same appearance as report builder as per …
5401df1 
…issue #410
@CraigClark
Copy link
Collaborator Author

inconsistent labels fixed with this commit on this branch

@CraigClark
Copy link
Collaborator Author

Search box moved to header and display of manage records on dashboard fixed with this commit

@CraigClark
Copy link
Collaborator Author

@NicoledeGreef I'm thinking booleans would be better as radios. It is more explicit than a checkbox. It would require an editor to choose between yes and no.

instead of

Image

We would have

Image

This would make it work the same way as Personal information, the only other boolean currently in use.

Do you approve this change?

@CraigClark
Copy link
Collaborator Author

Manage records page has same design as report pages with this commit

It wound be nice at some point to format the sort choices as radios. There is no option for this in UI, it would require custom code.

lkmorlan pushed a commit that referenced this issue Apr 23, 2024
@CraigClark @lkmorlan
Issue #410: Bold labels on form input and space between button and co…
39e4376 
…ntent on data dictionary import
lkmorlan pushed a commit that referenced this issue Apr 23, 2024
@CraigClark @lkmorlan
Issue #410: Enable search block in header on dashboard pages
c785f9b 
Remove search block from body of main dashboard page.
lkmorlan pushed a commit that referenced this issue Apr 23, 2024
@CraigClark @lkmorlan
Issue #410: Style summary of managed records
08b57a4
lkmorlan pushed a commit that referenced this issue Apr 23, 2024
@CraigClark @lkmorlan
Issue #410: Fix width of fieldsets for date fields on report builder
2126c82
lkmorlan pushed a commit that referenced this issue Apr 23, 2024
@CraigClark @lkmorlan
Issue #410: Make the manage page use the same exposed filter style as…
9c1a57b 
… the report builder
@lkmorlan
Copy link
Collaborator

Merged

@NicoledeGreef NicoledeGreef added the Sprint 17 April 25 - May 16 label Apr 25, 2024
@NicoledeGreef NicoledeGreef added the Sprint 18 May 17 - May 30 label May 16, 2024
CraigClark added a commit that referenced this issue May 24, 2024
@CraigClark
issue #410 make boleans explicitly yes or no input
f507dd9
@CraigClark
Copy link
Collaborator Author

Booleans made explicit with this branch https://github.com/bcgov/MFIN-Data-Catalogue/tree/410-booleans-to-explicit-yes-no @lkmorlan to review/merge

@CraigClark
Copy link
Collaborator Author

Sidebar nav touching side of screen on mobile is no longer an issue. A while ago I remove a bootstrap gap glass that was wrapping the entire container, that may have fixed it.

CraigClark added a commit that referenced this issue May 24, 2024
@CraigClark
issue #410 add space above side bar on mobile to prevent conten colli…
8c6ae1a 
…sion
@CraigClark
Copy link
Collaborator Author

Space added above sidebar on mobile fixed in this branch https://github.com/bcgov/MFIN-Data-Catalogue/tree/410-fix-spacing-on-side-bar
@lkmorlan please review/merge.

lkmorlan pushed a commit that referenced this issue May 24, 2024
@CraigClark @lkmorlan
Issue #410: Add space above side bar on mobile to prevent content col…
192447c 
…lision
lkmorlan pushed a commit that referenced this issue May 24, 2024
@CraigClark @lkmorlan
Issue #410: Make Boolean value take explicitly yes or no input
9d27dfc
lkmorlan added a commit that referenced this issue May 24, 2024
@lkmorlan
Issue #410: Check only fields that exist on a data_set when prevent p…
bf0d631 
…ublishing due to empty fields

Update tests for making field_critical_information display as radio button.

Fixes issue introduced in 9d27dfc.
@lkmorlan
Copy link
Collaborator

Merged

CraigClark added a commit that referenced this issue May 27, 2024
@CraigClark
issue #410 Add common region box to series to improve usability
0d93934 
This change make the relationship between series elements obvious
@CraigClark
Copy link
Collaborator Author

CraigClark commented May 27, 2024 •
edited by lkmorlan

@lkmorlan please review/merge

lkmorlan pushed a commit that referenced this issue May 27, 2024
@CraigClark @lkmorlan
Issue #410: Add common region box to series to improve usability
8e357b2 
This change make the relationship between series elements obvious.
@lkmorlan
Copy link
Collaborator

Merged

@CraigClark
Copy link
Collaborator Author

Closing this. All documented adjustments are done and there is no time left in the project for additional changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CraigClark CraigClark

Labels
Sprint 15 March 14 - April 3 Sprint 16 April 4- April 24 Sprint 17 April 25 - May 16 Sprint 18 May 17 - May 30 task a task that a dev team member needs to address
Projects
MFIN Data Catalogue
Status: Done
Milestone
Theming
Development

No branches or pull requests
3 participants
@CraigClark @lkmorlan @NicoledeGreef