Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rules_rust to recommended rules #15625

Closed
UebelAndre opened this issue Jun 6, 2022 · 15 comments
Closed

Add rules_rust to recommended rules #15625

UebelAndre opened this issue Jun 6, 2022 · 15 comments
Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: process

Comments

@UebelAndre
Copy link
Contributor

UebelAndre commented Jun 6, 2022

Description of the feature request:

I think rules_rust fits the criteria here for becoming a recommended set of rules (https://bazel.build/rules#recommended-rules). I'm filing this issue per the guidance there as well.

@UebelAndre
Copy link
Contributor Author

cc @hlopko, the current Googler admin for rule_rust.

@sgowroji sgowroji added type: feature request untriaged team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Jun 7, 2022
@Wyverald Wyverald added type: process team-Documentation Documentation improvements that cannot be directly linked to other team labels and removed type: feature request untriaged team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Jun 21, 2022
@Wyverald
Copy link
Member

cc @alexeagle @jin

We should replace this page with a community-maintained website as we discussed with the rules SIG. Preferably something like Awesome Bazel but not bottlenecked on one maintainer.

@hlopko
Copy link
Member

hlopko commented Jul 11, 2022

+1 @Wyverald

I think the criteria are a bit outdated (I think "No change in Bazel may break a recommended rule (with the default set of flags). If it happens, the change should be fixed or rolled back." is not followed anymore), so I don't know what the purpose of recommended rules is besides the increased visibility for Bazel newcomers.

In any case I think rules_rust do meet the criteria and I support adding them to the set of recommended rules.

@Wyverald
Copy link
Member

@philomathing Could we make a decision on where to host this "recommended rules" thing before 6.0? Would be nice to somewhat officially say "people, please go and look at the rules-SIG recommended list from now on".

@sventiffe
Copy link
Contributor

Is this depending on a 6.0 release? You could setup the external page and link to it from https://bazel.build/rules#recommended-rules later.

Can the external page be mirrored so that we can change the link in case the page goes down for any reason?

@Wyverald
Copy link
Member

We discussed this in yesterday's rules SIG meeting; I agree that it can be done any time, I just mentioned 6.0 as an arbitrary deadline since this has been dragging on for a while. On the other hand @alexeagle also seemed to think that this can wait until BCR official launch is settled since that's higher priority.

I don't think it's necessary for Google to mirror that page -- the impact of it being down is not too high (unlike mirrored download archives, etc).

@sgowroji sgowroji added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Nov 22, 2022
@alexeagle
Copy link
Contributor

The BCR official launch is now complete, which is the last prerequisite mentioned on this thread. I guess we should bring this up at the SIG meeting on 24 January again.

Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Mar 25, 2024
@UebelAndre
Copy link
Contributor Author

I would still like this.

@github-actions github-actions bot removed the stale Issues or PRs that are stale (no activity for 30 days) label Mar 27, 2024
@Emasoft
Copy link

Emasoft commented May 12, 2024

We need this. We also need official Rust support in Bazel.

@alexeagle
Copy link
Contributor

What does official support mean to you?

@UebelAndre
Copy link
Contributor Author

As a maintainer of rules_rust, it would certainly feel good to have the rules on the recommended page. Are there any reservations to including it?

@Wyverald
Copy link
Member

This has dragged on long enough -- I say we just add it to the recommended page. The "rules catalog" will come when it comes. Happy to review a PR.

@UebelAndre
Copy link
Contributor Author

UebelAndre commented May 17, 2024

This has dragged on long enough -- I say we just add it to the recommended page. The "rules catalog" will come when it comes. Happy to review a PR.

@Wyverald Where does the change need to be made?

@Wyverald
Copy link
Member

Go to https://bazel.build/rules#recommended-rules, and click "View source"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants