-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rules_rust
to recommended rules
#15625
Comments
cc @hlopko, the current Googler admin for |
cc @alexeagle @jin We should replace this page with a community-maintained website as we discussed with the rules SIG. Preferably something like Awesome Bazel but not bottlenecked on one maintainer. |
+1 @Wyverald I think the criteria are a bit outdated (I think "No change in Bazel may break a recommended rule (with the default set of flags). If it happens, the change should be fixed or rolled back." is not followed anymore), so I don't know what the purpose of recommended rules is besides the increased visibility for Bazel newcomers. In any case I think |
@philomathing Could we make a decision on where to host this "recommended rules" thing before 6.0? Would be nice to somewhat officially say "people, please go and look at the rules-SIG recommended list from now on". |
Is this depending on a 6.0 release? You could setup the external page and link to it from https://bazel.build/rules#recommended-rules later. Can the external page be mirrored so that we can change the link in case the page goes down for any reason? |
We discussed this in yesterday's rules SIG meeting; I agree that it can be done any time, I just mentioned 6.0 as an arbitrary deadline since this has been dragging on for a while. On the other hand @alexeagle also seemed to think that this can wait until BCR official launch is settled since that's higher priority. I don't think it's necessary for Google to mirror that page -- the impact of it being down is not too high (unlike mirrored download archives, etc). |
The BCR official launch is now complete, which is the last prerequisite mentioned on this thread. I guess we should bring this up at the SIG meeting on 24 January again. |
Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale. |
I would still like this. |
We need this. We also need official Rust support in Bazel. |
What does official support mean to you? |
As a maintainer of |
This has dragged on long enough -- I say we just add it to the recommended page. The "rules catalog" will come when it comes. Happy to review a PR. |
@Wyverald Where does the change need to be made? |
Go to https://bazel.build/rules#recommended-rules, and click "View source" |
Description of the feature request:
I think rules_rust fits the criteria here for becoming a recommended set of rules (https://bazel.build/rules#recommended-rules). I'm filing this issue per the guidance there as well.
The text was updated successfully, but these errors were encountered: