-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basti: Add option to save logs #62
Labels
enhancement
New feature or request
Comments
In order for such logging to be more useful, we also need to add more debug/trace logs to Basti CLI. |
More logging would be nice. But it would already be great if what is currently displayed on the terminal is stored in a log file with a timestamp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Description
The Basti CLI currently only logs to the terminal. This issue proposes a solution that would allow logging to log file.
A logging config option would allow users to specify a file or location (or a default location would be used otherwise) where the Basti CLI would log its activity. This would be beneficial for a number of reasons, including:
Proposed Solution
Building on issue #59 it would make sense to create a
.config.yml
(or json) file in this~/.basti
directory. This would then have a section for logging.save_logs
would enable or disable logging to a filelog_line_limit
is intended to limit the size of the file. This avoids log files that end up GB's in size.save_location
allows the user to configure a save location, but default this is stored in the~/.basti
directory.The logging itself should always be prefixed with a timestamp. This helps with troubleshooting events in time and allows you to check with AWS logging as well.
Initially, I'd recommend that these settings can just be modified through the
config.yml
file, but later a command could be added that changes these settings.basti config logs.save_logs true
for example.Related Issues/PRs
#59
The text was updated successfully, but these errors were encountered: