-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content Not Refreshed Correctly for pasteEventHasPlainTextOnly Special Case #1103
Comments
If it helps any, the issue appears to be fixed if I change this statement from |
…aste and trix-change callbacks are refreshed in the editor when pasting plain text
@chadrschroeder any workaround until this get fixed? |
Unfortunately, I don't think there's a clean way to work around this other than to serve a customized version of the Trix JavaScript where the |
Say I create a paste handler that is going to change the incoming text like:
If I paste text from an application like Microsoft Word, the
clipboardData
types will include "text/plain", "text/html", "text/rtf" and "Files". The Trix editor will show the text in bold after pasting.If I paste text from a plain text editor like TextEdit, the
clipboardData
types will only include "text/plain". We'll get into the specialpasteEventHasPlainTextOnly
handling. The Trix editor won't show the text in bold after pasting. It will switch the pasted content to bold if you type another character into the editor which seems to indicate that this special handling isn't correctly refreshing the editor after thetrix-paste
event is done.This doesn't affect Trix version 1.3.1 that is running at https://trix-editor.org/.
Do we still need the workaround that was added back in 2019 here? The code comment near the
pasteEventHasPlainTextOnly
handling says:The Chromium bug report is now marked as fixed. Can the workaround be removed now since it's breaking the paste behavior for plain text editors?
Details
The text was updated successfully, but these errors were encountered: