-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Nominal Typing page #521
Comments
UppaJung
added a commit
to UppaJung/typescript-book
that referenced
this issue
Sep 16, 2019
Addresses: basarat#521 Uses technique from: microsoft/TypeScript#32891 Also note: This "& string" that remains in this code sample appears to do nothing as of TypeScript 3.6.2, but presumably should be kept for backwards compat.
I've submitted a pull request. I hope you or others feel empowered to submit your own in the future, because the book is a widely-used resource and I'm sure many people would have benefited from seeing this information on that page 12 days earlier. My experience in submitting a few PRs in the past is that @basarat has been very open to them, and will accept something good over something that perfectly matches his style. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The instructions for Nominal Typing don't work anymore.
See also: microsoft/TypeScript#32891 (comment)
The text was updated successfully, but these errors were encountered: