Performance issue with internal trie structure?

[adbar]

Hi, thanks for the package, which I'm using a lot in different projects. I was profiling my code with pprofile and noticed a potential performance issue in the function get_tld_names().

It's a recursive fonction but it does not seem to be the problem here, the trie data structure in trie.py appears to be slow, because adding elements to the trie is slow or maybe because the fonction is called (too) often?

Here are the lines that caught my attention:

tld/src/tld/base.py

Line 79 in 53dd803

def get_tld_names(cls, fail_silently: bool = False, retry_count: int = 0):

tld/src/tld/utils.py

Line 213 in 817a813

for line in local_file:

tld/src/tld/utils.py

Line 227 in 817a813

trie_add(f"{line.strip()}", private=private_section)

Could you please have a look at this?