Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Against Python 3.10 and Django 4.0 #285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Test Against Python 3.10 and Django 4.0 #285

wants to merge 1 commit into from

Conversation

saadmk11
Copy link

@saadmk11 saadmk11 commented Feb 19, 2022 •
edited

Test Against Python 3.10 and Django 4.0

Adds:

  • Test Against Python 3.10
  • Test Against Django 4.0
  • Update code to support Django 4.0

Fixes:

  • GitHub Actions Matrix running tests only for Django 3.2
  • Elasticsearch version mismatch with tox environment on GitHub Actions Matrix

Issue:

  • django-elasticsearch-dsl version 6.x has not been ported to support Django 4.0. So, tests with Django 4.0 and Elasticsearch 6 have been omitted.

Closes #275

@millerf millerf mentioned this pull request Oct 6, 2022
Closed
@ddelange
Copy link

@barseghyanartur is there something I can support with to get django v4 support merged?

@ddelange
Copy link

django-elasticsearch-dsl 7.3 is also tested against python 3.11 and django 4.1 by the way 💪

@barseghyanartur
Copy link
Owner

@saadmk11

Thanks. I'll review it as soon as possible.

@ddelange
Copy link

ddelange commented Apr 4, 2023

hi 👋

I just successfully tested the following combination (this branch) on python 3.11:

django-elasticsearch-dsl-drf @ https://github.com/barseghyanartur/django-elasticsearch-dsl-drf/archive/92c7bf76beefeb0b871cd60725e489371ae5e92c.zip
django-elasticsearch-dsl==7.3
django==4.2
djangorestframework==3.14.0

@ddelange
Copy link

ddelange commented Nov 3, 2023

@barseghyanartur kind reminder:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs to be tested work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test against Django 4.0, 4.1 and Python 3.10
3 participants
@saadmk11 @ddelange @barseghyanartur