-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch write ignoring failed writes #29
Comments
https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_BatchWriteItem.html For
But
|
Sorry for the delay in responding. Since the error message only comes about through throttling and eventually throttling will let it through, infinite is probably not a bad option. (I'm using this in a lambda function which would time out on its own in 5 minutes or less, I'm not sure what a standard node function would do if a runaway process can be killed by the node engine with express. But the throttling by definition basically says "eventually this will succeed") For delay strategy, probably an exponential backoff strategy would be best, though maybe a setting between exponential and linear would be better. |
The response back from DocumentClient on BatchWrite will include any failed writes, which usually need to be resubmitted (sometimes with a linear backoff)
The call from DynamoDb returns UnprocessedItems but batch_write.js will not check this, and this results in missed items when writing batches to the table.
will try and submit a PR when I have time but I have code from a different attempt which was working but would need to be redone to fit in with how this file works
The text was updated successfully, but these errors were encountered: