-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fullscreen-compilation: remove magic numbers #40
Comments
Heh, I think of something else when I read FFS. Whether magic text FFSActual is more readable than magic number 2 I guess is debatable. Style wise if you do it like this then arguably you should do it for Anyway I see the point and will take it into consideration if I end up refactoring this patch. |
Hence why the names can be improved :)
Correct me if I'm wrong, but I don't think I saw anything but 0 and 1 being assigned to |
One more thing I just noticed (haven't tested it) is that if (fullscreen != c->isfullscreen) { // only send property change if necessary |
While trying to edit some stuff I found myself not knowing what 2 or 3 meant. I think it's best to use enum instead; The names can probably be improved, but this is certainly better than what we currently have, magic numbers.
I'd supply the fix myself, but I see that the patch has evolved a bit more compared to what I have on my build. Unfortunately the changes don't look interesting enough for me to bother porting them. Here's a diff on my build if you're interested: https://dpaste.com/82NLG5QT6
The text was updated successfully, but these errors were encountered: