Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark theme #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add dark theme #27

wants to merge 3 commits into from

Conversation

stoivo
Copy link

@stoivo stoivo commented Dec 8, 2016

closes #26

screen shot 2016-12-08 at 20 51 41

@stoivo
Copy link
Author

stoivo commented Dec 8, 2016

As you can see I am not a pro designer but it looks better then the bright one to me.

Do you want me to add a screenshot to README.md?

@stoivo
Copy link
Author

stoivo commented Jan 6, 2017

ping

@stoivo
Copy link
Author

stoivo commented Jan 20, 2017

@aziz @kl0tl

@FichteFoll
Copy link

FichteFoll commented Jan 29, 2017

Please darken the red background on the file name a bit. Otherwise this does the job.

@aziz
Copy link
Owner

aziz commented Jan 29, 2017

I don't like the colors, I'm not gonna merge this. make something more decent based on one of the popular dark themes and I'll merge it

@stoivo
Copy link
Author

stoivo commented May 25, 2017

This took too much time.
Is this good?
screen shot 2017-05-26 at 00 22 52

My preferred theme is Tubnil.

@stoivo
Copy link
Author

stoivo commented Jun 1, 2017

Thoughts?

@stoivo
Copy link
Author

stoivo commented Jun 7, 2017

@nivir, any thoughts?

@nivir
Copy link

nivir commented Jun 7, 2017

@stoivo personally I never like the dark background and red color, not sure what you can improve. For me I am happy as it is now with Mac Classic.tmTheme :)

@stoivo
Copy link
Author

stoivo commented Jun 7, 2017

screen shot 2017-06-07 at 12 43 13

@FichteFoll
Copy link

Since I'm also a tubnil user, purple and pink are perfectly fine for me. I also considered the red to be too offensive and distracting before.

@stoivo
Copy link
Author

stoivo commented Jun 8, 2017

I agree, it was too offensive.

@stoivo
Copy link
Author

stoivo commented Aug 18, 2017

ping

@stoivo
Copy link
Author

stoivo commented Sep 10, 2017

pong @aziz @FichteFoll

@stoivo
Copy link
Author

stoivo commented Oct 6, 2017

I am tired of waiting, any feedback is better than this...

@FichteFoll
Copy link

Not my repo, but I mentioned earlier that I like the latest iteration of this.

Generally, it would seem better to have the custom syntax definition use some of the standardized scope names instead of having to bundle custom color schemes, but this would need some exploration. Having a bright and dark scheme should work as a band-aid.

@stoivo
Copy link
Author

stoivo commented Nov 28, 2017

@aziz hello

@stoivo
Copy link
Author

stoivo commented Jun 8, 2018

ping @aziz

@FichteFoll
Copy link

FichteFoll commented Jun 8, 2018

Ideally the custom syntax would just use normal scope names and region.<color>ish scopes for emphasis of specific areas if needed. That way no scheme overrides are necessary and it will work on every scheme, bright or dark.

@stoivo
Copy link
Author

stoivo commented Jun 8, 2018

@FichteFoll, I might take a look at that. If/when I get the time.

@Koolstr
Copy link

Koolstr commented Nov 12, 2018

Honestly, why has this still not been implemented? The hard work was already taken care of. At least implement this temporary workaround. Such a crucial plugin needs better styling.

Why can't this plugin simply leave the styling to the app's default, basically matching the user's currently applied Sublime Text theme? That could happen by not including any styling, or perhaps setting this plugin's styling to match the app's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark Color Scheme Variant
5 participants