-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integration-tests: Don't use lo interface for XDP, create some veths instead #422
Labels
good first issue
Good for newcomers
help wanted
Extra attention is needed
test
A PR that improves test cases or CI
Comments
Don't use veths, use dummy interfaces. |
murex971
added a commit
to murex971/aya
that referenced
this issue
Mar 29, 2023
Fixes: aya-rs#422 Signed-off-by: murex971 <[email protected]>
murex971
added a commit
to murex971/aya
that referenced
this issue
Mar 29, 2023
Fixes: aya-rs#422 Signed-off-by: murex971 <[email protected]>
murex971
added a commit
to murex971/aya
that referenced
this issue
Mar 29, 2023
Fixes: aya-rs#422 Signed-off-by: murex971 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Good for newcomers
help wanted
Extra attention is needed
test
A PR that improves test cases or CI
Currently, integration tests are attaching XDP programs to
lo
inteface:aya/test/integration-test/src/tests/load.rs
Line 24 in f3262e8
That's not a good approach, it's too intrusive, especially if the test fails or if for some reason the XDP program doesn't get unloaded.
lo
, as well as any already existing NICs, shouldn't be touched.To test XDP, we should rather create some new, fake veth interfaces, which then we remove after running a test. Such interfaces should be also safe to remove manually if anything goes wrong with cleaning up after the test.
The text was updated successfully, but these errors were encountered: