Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classname notation/conversion #18

Open
GertSallaerts opened this issue Apr 23, 2017 · 0 comments
Open

Classname notation/conversion #18

GertSallaerts opened this issue Apr 23, 2017 · 0 comments

Comments

@GertSallaerts
Copy link

Quick question. As you state this project is meant to allow us to write plain CSS and end up with JSS, wouldn't it make more sense to strip the dots from classnames and global-ize any global selectors?

Take this input:

.button { background-color: salmon; }
p { color: green; }

With output

exports.default = {
    ".button": {
        "backgroundColor": "salmon"
    }
    "p": {
        "color": "green"
    }
};

While I expected the output to be something more like this:

exports.default = {
    "button": {
        "backgroundColor": "salmon"
    }
    "@global": {
        "p" {
            "color": "green"
        }
    }
};
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant