Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong parser on float property #17

Open
BrRenat opened this issue Apr 12, 2017 · 4 comments
Open

wrong parser on float property #17

BrRenat opened this issue Apr 12, 2017 · 4 comments
Labels

Comments

@BrRenat
Copy link
Contributor

BrRenat commented Apr 12, 2017

Maybe I do not understand something, but when i set property float float: left it transform to
'cssFloat': 'left'

@DenisIzmaylov
Copy link
Contributor

DenisIzmaylov commented Apr 12, 2017

Good point! Thank you.

It seems the problem in PostCSS:

We'll need to investigate more deeply why the latests fixes by @ai are not working for https://github.com/axept/prejss-postcss-parser while it's using pretty new version of postcss-js.

@ai
Copy link

ai commented Apr 12, 2017

postcssJs.objectify transforms float to cssFloat, because it is reserved keyword in some browsers

@DenisIzmaylov
Copy link
Contributor

Andrey @ai, thanks for clarification. But it seems stringified keys like:

result['float'] = 'left'

Could be used without any problems. Or I'm wrong here?

@ai
Copy link

ai commented Apr 22, 2017

Hm. To understand how to fix problem, I need to know what is the real problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants