Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add millisecond L and microsecond U support in time_feature #3113

Open
hohe12ly opened this issue Jan 29, 2024 · 1 comment
Open

add millisecond L and microsecond U support in time_feature #3113

hohe12ly opened this issue Jan 29, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@hohe12ly
Copy link

Description

Currently, the finest temporal resolution (frequency) that the base module and the lag and seasonality module in time_feature is secondly (S). Is it straightforward to add millisecond and microsecond? Pandas tseries support these two frequencies (L and U).

It seems to support millisecond and microsecond resolutions, the following codes need to be extended:

  • time_feature/_base.py:
    • add milli_of_second(), micro_of_second(), and possibly micro_of_milli()
    • change time_features_from_frequency_str() accordingly.
  • time_feature/lag.py:get_lags_for_frequency()
    • add _make_lags_for_millisecond(), _make_lags_for_microsecond()
    • add 'L' and 'U' support
  • time_feature/seasonality.py: add L and U support in DEFAULT_SEASONALITIES

If it is more complicated than that, could you please explain a bit? Thanks.

References

@hohe12ly hohe12ly added the enhancement New feature or request label Jan 29, 2024
@kashif
Copy link
Contributor

kashif commented Mar 14, 2024

@hohe12ly indeed can you kindly send a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants