Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Parsing is not robust enough #35

Open
ericdbarry opened this issue Jul 27, 2019 · 0 comments
Open

HTML Parsing is not robust enough #35

ericdbarry opened this issue Jul 27, 2019 · 0 comments

Comments

@ericdbarry
Copy link

ericdbarry commented Jul 27, 2019

I am pointing to a login page that has some oddities in it, exposing some assumptions about the pages being processed.

Two examples:

  1. escape function does not like None being passed in
  2. name tag is required, yet login_form_html_node.findall(".//input")) does not filter

Both of these are valid markup - the first being a boolean attribute being present, the second being an input tag without a name attribute.

ericdbarry added a commit to ericdbarry/awsprocesscreds that referenced this issue Jul 27, 2019
ericdbarry added a commit to ericdbarry/awsprocesscreds that referenced this issue Jul 27, 2019
@ericdbarry ericdbarry changed the title HTML Parsing is not defensive enough HTML Parsing is not robust enough Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant