Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Expression failure in servicecatalog-tools--StartCDKDeploy code #85

Open
CrazyCatMandy opened this issue May 6, 2022 · 0 comments

Comments

@CrazyCatMandy
Copy link

When trying to run the install of a cdk package through service catalog using the supplied tools there are issues with the integration with crhelper.

Firstly, as crhelper is not on AWS as a standard layer the code does not work out of the box. It would be helpful to either provide information about the creation of a lambda layer (with a variable of that lambda layer to pass in, and preferably instructions for IaC rather than console) or to provide the correct version of crhelper that should be used as part of the package to be deployed.

The main issue, however, is the integration between the lambda and crhelper.
In crhelper code file resource_helper.py for version 2.0.10 line 271 a variable ScheduledExpression is set using the value of polling_interval from the CfnResource class definition.
At the top of the lambda servicecatalog-tools--StartCDKDeploy helper is set to be the CfnResource but with a polling_interval=1
This results in the following:
ScheduleExpression='rate(1 minutes)'
Notice the pleural of minutes is still there. This causes an issue as follows:
image

I have not come across a version of crhelper which deals with this more effectively so the easiest work around for this is to set the polling_interval to be 2 instead at the top of the Lambda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant