-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not honouring parameters configuration file for generated Config Rule Resource Names #414
Labels
Comments
julienbonastre
changed the title
Bug - Not honouring parameters configuration file for generated Config Rule Resource Names
Not honouring parameters configuration file for generated Config Rule Resource Names
Apr 17, 2023
The validation that
Before implementing a change like this, I'm curious why it's necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Easy. Just use any recent version of
rdk
todeploy
orcreate_rule_template
and take note of the AWS Config Rule "Name" value. It is not what is configured in theparameters.json
file under theParameters.RuleName
field as expected but the actual directory name it discovers the file withinThis can be clearly seen in the source:
aws-config-rdk/rdk/rdk.py
Lines 3319 to 3328 in ff944bc
The version of our code being used
This is seen in latest: https://github.com/awslabs/aws-config-rdk/releases/tag/0.12.0 but no doubt extends for the lifespan of this solution
Any modifications you've made relevant to the bug
None
Anything unusual about your environment or deployment
None, this will occur in a stock, clean build environment
Suggestion
Extend a method that is used to actually read the configured RuleName value from the parameters.json file during Resource instance creation, rather than the directory name.
It would be nice to use that name consistently throughout the framework however I can see it is used and referenced heavily throughout as an index for many other mappings so it's probably easiest to just perform this step at some point where it parses the JSON config and generate a new class property to capture/hold this
PublishedRuleName
or something akinThe text was updated successfully, but these errors were encountered: