-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registering buffers in Components #236
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Component class implements a
_register_parameters
method that registers the loss' constructor arguments.This currently works without glitches where Renate manages the
state_dict
of Learner, Model and others. However, once the move to relying on Lightning for all checkpointing is complete (in #218) this fails as registering the constructor args (say_weight
) returns it in the state_dict, and causes an error when restoring the model from checkpoint. The 'fix' for now is going to by changingRenateModule
'sload_state_dict
to usestrict=False
.This issue should help cleanup the components code too.
The text was updated successfully, but these errors were encountered: