Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperparameters not shell escaped #128

Open
bstriner opened this issue May 23, 2022 · 0 comments
Open

Hyperparameters not shell escaped #128

bstriner opened this issue May 23, 2022 · 0 comments

Comments

@bstriner
Copy link

Describe the bug
Hyperparameters with spaces get passed as separate command line tokens

To reproduce
Create a hyperparameter like "key" set it to "a b". Toolkit will invoke user script with "--key a b" instead of "--key 'a b'".

Expected behavior
Expect hyperparameters to be passed to script as arguments. Requiring hyperparameters to already be shlex quoted seems unexpected. The commands are correctly passed to Popen but differently parsed when asyncio is used.

Screenshots or logs
If applicable, add screenshots or logs to help explain your problem.

System information
A description of your system.

  • Include the version of SageMaker Training Toolkit you are using.
  • If you are using a prebuilt Amazon SageMaker Docker image, provide the URL.
  • If you are using a custom Docker image, provide:
    • framework name (eg. PyTorch)
    • framework version
    • Python version
    • processing unit type (ie. CPU or GPU)

Additional context
Add any other context about the problem here.

@bstriner bstriner mentioned this issue May 23, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant