-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyperparameters not shell escaped #128
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Hyperparameters with spaces get passed as separate command line tokens
To reproduce
Create a hyperparameter like "key" set it to "a b". Toolkit will invoke user script with "--key a b" instead of "--key 'a b'".
Expected behavior
Expect hyperparameters to be passed to script as arguments. Requiring hyperparameters to already be shlex quoted seems unexpected. The commands are correctly passed to Popen but differently parsed when asyncio is used.
Screenshots or logs
If applicable, add screenshots or logs to help explain your problem.
System information
A description of your system.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: