Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge old priority labels #4538

Closed
goatgoose opened this issue May 2, 2024 · 2 comments
Closed

Purge old priority labels #4538

goatgoose opened this issue May 2, 2024 · 2 comments

Comments

@goatgoose
Copy link
Contributor

Problem:

s2n-tls Github issues are assigned a priority label to indicate how urgently the issue should be resolved, which provides better visibility into which issues should be worked on. However, some issues were assigned priority labels many years ago, which often no longer align with the current goals for s2n-tls. This complicates discovering which issues should be worked on, since the priority label isn't reliable for old issues.

Solution:

A date should be selected for which the priority label is no longer relevant, and all priority labels on and before this date should be purged. After the label purge, we can go back through old issues and give them a new priority based on the current direction of the library.

@dougch
Copy link
Contributor

dougch commented May 8, 2024

GitHub still lacks an interactive bulk edit feature, but the cli could do this:

gh issue list -S "is:open is:issue label:priority/high created:<2023-01-01"
gh issue edit $ISSUENUMBER --remove-label "priority/high"

...there's also https://github.com/XAMPPRocky/octocrab

@goatgoose
Copy link
Contributor Author

High and medium priority labels before 2022 have been purged with the following script:
https://gist.github.com/goatgoose/05ae12b51a4739869323a5b61e54c1c7

❯ ./purge_old_labels.sh
Removing priority/high, labels:

Removing priority/medium labels:

https://github.com/aws/s2n-tls/issues/1634
1634: Protocol version helper functions
https://github.com/aws/s2n-tls/issues/1488
1488: Add Codebuild CI with GCC 4.1.2
https://github.com/aws/s2n-tls/issues/790
790: Fail build on uninitialized variables
https://github.com/aws/s2n-tls/issues/789
789: Fail build on unsafe integer conversions
https://github.com/aws/s2n-tls/issues/780
780: Make SSL Session Cache callbacks non-blocking
https://github.com/aws/s2n-tls/issues/775
775: Add s2n_x509_trust_store API's
https://github.com/aws/s2n-tls/issues/752
752: Make Public/Private Key Sanity Checking Optional
https://github.com/aws/s2n-tls/issues/738
738: Run Cppcheck After Preprocessor to Reduce False Positives
https://github.com/aws/s2n-tls/issues/714
714: Add s2n_config_dup() API
https://github.com/aws/s2n-tls/issues/705
705: Capture OpenSSL error codes
https://github.com/aws/s2n-tls/issues/695
695: [RFC 7633] Support OSCP Must-Staple x509 Extension
https://github.com/aws/s2n-tls/issues/693
693: Update s2n read API's to copy data instead of returning pointers to internal data
https://github.com/aws/s2n-tls/issues/691
691: Integrate with Cryptography.io X509 Test Vectors
https://github.com/aws/s2n-tls/issues/690
690: Integrate with Google's x509 Test Suite
https://github.com/aws/s2n-tls/issues/685
685: Reduce timing leakage from hash_digest_two_compression_rounds
https://github.com/aws/s2n-tls/issues/683
683: Make standalone CONTRIBUTING.md File
https://github.com/aws/s2n-tls/issues/654
654: Integrate with US NIST PKI x509 Test Suite
https://github.com/aws/s2n-tls/issues/653
653: Integrate with Netflix's BetterTLS x509 Test Suite
https://github.com/aws/s2n-tls/issues/644
644: SSLv3 s2n_hmac_test uses keys of the wrong lengths
https://github.com/aws/s2n-tls/issues/595
595: Integrate with FrankenCert x509 Test Suite
https://github.com/aws/s2n-tls/issues/576
576: Ability to configure Minimum TLS Version
https://github.com/aws/s2n-tls/issues/572
572: Timing balancing code copies more bytes than necessary
https://github.com/aws/s2n-tls/issues/505
505: Unify s2n_cert_auth_type across client/server mode
https://github.com/aws/s2n-tls/issues/497
497: Add support for a Windows Build
https://github.com/aws/s2n-tls/issues/457
457: [RFC 6962] s2n Client can Validate Signed Certificate Timestamp TLS Extension
https://github.com/aws/s2n-tls/issues/451
451: Create Lambda to periodically maximize Fuzz Corpus & send PR with updated Corpus
https://github.com/aws/s2n-tls/issues/435
435: Add TLS-Attacker Integration Test
https://github.com/aws/s2n-tls/issues/394
394: [RFC 8032] Add Support for EdDSA Signature Algorithms
https://github.com/aws/s2n-tls/issues/341
341: Add fuzz tests with random allocation failures
https://github.com/aws/s2n-tls/issues/325
325: WATCH-list: client side authentication in s2n
https://github.com/aws/s2n-tls/issues/291
291: Add BoringSSL protocol tests to CI
https://github.com/aws/s2n-tls/issues/210
210: https libraries using S2N?
https://github.com/aws/s2n-tls/issues/159
159: Why do (some) unexpected messages cause neither an alert to be sent, nor flushing of the connection?
https://github.com/aws/s2n-tls/issues/17
17: Add support for getentropy() and getrandom() 
https://github.com/aws/s2n-tls/issues/16
16: Include regression tests for ABI stability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants