Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidetrail readme contains invalid instructions for running tests locally #4466

Open
goatgoose opened this issue Mar 21, 2024 · 1 comment
Open

Comments

@goatgoose
Copy link
Contributor

goatgoose commented Mar 21, 2024

Problem:

The sidetrail readme contains instructions for running the sidetrail tests locally. These instructions indicate that a sidetrail Dockerfile should be used to build an image. However, this Dockerfile was removed in #3518, so it no longer exists.

Solution:

We should remove the invalid reference from the readme, and instead link to the instillation scripts to setup the dependencies locally without docker.

After #4479 is resolved, we can link to the sidetrail docker image again.

@maddeleine
Copy link
Contributor

Hah, apparently someone has noticed this before: #3881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants