Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang format all .c and .h files #4443

Open
jmayclin opened this issue Feb 26, 2024 · 0 comments
Open

clang format all .c and .h files #4443

jmayclin opened this issue Feb 26, 2024 · 0 comments

Comments

@jmayclin
Copy link
Contributor

Problem:

Not all files are clang formatted. The missed files seem to be

        modified:   codebuild/bin/s2n_dynamic_load_test.c
        modified:   tests/LD_PRELOAD/allocator_overrides.c
        modified:   tests/benchmark/utils/shared_info.h
        modified:   tests/cbmc/*
        modified:   tests/ctverif/*
        modified:   tests/features/*
        modified:   tests/fuzz/*
        modified:   tests/s2n_test.h
        modified:   tests/sidetrail/*
        modified:   tests/viz/s2n_state_machine_viz.c

Solution:

find . -type f \( -name "*.c" -o -name "*.h" \) -exec clang-format -i {} \;

However, the standard seems to be that s2n-tls will manually review all clang-format based changes. With the 243 non-clang formatted files, that would take quite a long time to review. I'm generally comfortable with automated contributions/tooling, but if we don't want to do that then this will need to be split into multiple PRs.

Requirements / Acceptance Criteria:

All .c and .h files must be clang formatted.

Out of scope:

Nothing is out of scope. All .c. and .h files in the repo must be clang formatted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants