Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: JSII-Pacmak adds extra } #4299

Open
DanielMSchmidt opened this issue Oct 17, 2023 · 0 comments
Open

C#: JSII-Pacmak adds extra } #4299

DanielMSchmidt opened this issue Oct 17, 2023 · 0 comments
Labels
bug This issue is a bug. p1

Comments

@DanielMSchmidt
Copy link
Contributor

Describe the bug

When we run jsii-pacmak -v --target dotnet in the build process of cdktf-provider-oci we run into ~50 errors across all sorts of resouces that all appear to have one or two extra } at the end the file.

Expected Behavior

Compiling the bindings from the source TS correctly for C#

Current Behavior

This gist shows one example of a TS file and a corresponding C# file, at the very end of the C# file you can see two extra }.

Reproduction Steps

  • Create new project with cdktf 0.18.2 (or any recent version) and constructs installed
  • This gist Copy the TS file of the gist.
  • Run pacmak against it, see the error

Possible Solution

No response

Additional Information/Context

No response

SDK version used

[email protected], [email protected]

Environment details (OS name and version, etc.)

OSX Ventura & Ubuntu on GH Runner

@DanielMSchmidt DanielMSchmidt added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 17, 2023
@mrgrain mrgrain added p1 and removed needs-triage This issue or PR still needs to be triaged. labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p1
Projects
None yet
Development

No branches or pull requests

2 participants